Wireshark · Ethereal-dev: [Ethereal-dev] ICQ dissector

[Jeroen Ruigrok van der Werven <jruigrok@xxxxxxxxxxxxxxxx>]

I think the ICQ dissector code causes lockups with LICQ's SSL secure
channel feature.

After a capture of less than 1000 packets/frames it rereads the
temporary file back in and then just hangs in RUN state.
This is all on a FreeBSD 4.1.1-STABLE box.

When watching the process with top it seems to demand more and more CPU
time and more memory whilst the progess bar shows no progress.

So I forced a coredump.

#0  0x284bff79 in malloc_bytes (size=8)
    at /usr/src/lib/libc/../libc/stdlib/malloc.c:666
#1  0x284c01e1 in imalloc (size=8)
    at /usr/src/lib/libc/../libc/stdlib/malloc.c:714
#2  0x284c0398 in irealloc (ptr=0x82e2360, size=8)
    at /usr/src/lib/libc/../libc/stdlib/malloc.c:801
#3  0x284c0b1d in realloc (ptr=0x82e2360, size=8)
    at /usr/src/lib/libc/../libc/stdlib/malloc.c:1126
#4  0x283640b6 in g_realloc (mem=0x82e2360, size=8) at gmem.c:338
#5  0x809791c in dissect_icqv5Client (pd=0x82c8000 "", offset=42, fd=0x82b28d8, 
    tree=0x0) at packet-icq.c:2063
#6  0x80984fc in dissect_icqv5 (pd=0x82c8000 "", offset=42, fd=0x82b28d8, 
    tree=0x0) at packet-icq.c:2424
#7  0x8098592 in dissect_icq (pd=0x82c8000 "", offset=42, fd=0x82b28d8, 
    tree=0x0) at packet-icq.c:2442
#8  0x8145145 in dissector_try_port (sub_dissectors=0x8202440, port=4000, 
    tvb=0x8283d68, pinfo=0x8201200, tree=0x0) at packet.c:1303
#9  0x80ee543 in decode_udp_ports (tvb=0x8283d98, offset=8, pinfo=0x8201200, 
    tree=0x0, uh_sport=49163, uh_dport=4000) at packet-udp.c:121
#10 0x80ee857 in dissect_udp (tvb=0x8283d98, pinfo=0x8201200, tree=0x0)
    at packet-udp.c:191
#11 0x8145159 in dissector_try_port (sub_dissectors=0x8202220, port=17, 
    tvb=0x8283d98, pinfo=0x8201200, tree=0x0) at packet.c:1306
#12 0x809a03f in dissect_ip (tvb=0x8283d08, pinfo=0x8201200, tree=0x0)
    at packet-ip.c:956
#13 0x8145159 in dissector_try_port (sub_dissectors=0x8202020, port=2048, 
    tvb=0x8283d08, pinfo=0x8201200, tree=0x0) at packet.c:1306
#14 0x808e2a5 in ethertype (etype=2048, tvb=0x8283cd8, offset_after_etype=14, 
    pinfo=0x8201200, tree=0x0, fh_tree=0x1, item_id=377)
    at packet-ethertype.c:114
#15 0x808e088 in dissect_eth (tvb=0x8283cd8, pinfo=0x8201200, tree=0x0)
    at packet-eth.c:306
#16 0x808eb70 in dissect_frame (tvb=0x8283cd8, pinfo=0x8201200, tree=0x0)
    at packet-frame.c:135
#17 0x8144cf6 in dissect_packet (p_tvb=0x82e2340, pseudo_header=0x824232c, 
    pd=0x82c8000 "", fd=0x82b28d8, tree=0x0) at packet.c:1041
#18 0x814317a in epan_dissect_new (pseudo_header=0x824232c, data=0x82c8000 "", 
    fd=0x82b28d8, tree=0x0) at epan.c:90
#19 0x810a043 in add_packet_to_packet_list (fdata=0x82b28d8, cf=0x81f0f60, 
    pseudo_header=0x824232c, buf=0x82c8000 "", refilter=1) at file.c:646
#20 0x810a41a in read_packet (cf=0x81f0f60, offset=42053) at file.c:805
#21 0x810996c in read_cap_file (cf=0x81f0f60, err=0xbfbfe2f8) at file.c:356
#22 0x8107cee in do_capture (capfile_name=0x0) at capture.c:510
#23 0x81355cd in capture_prep_ok_cb (ok_bt=0x8283060, parent_w=0x827b200)
    at capture_dlg.c:490
#24 0x28283f67 in gtk_marshal_NONE__NONE (object=0x8283060, 
    func=0x8135148 <capture_prep_ok_cb>, func_data=0x827b200, args=0xbfbfe934)
    at gtkmarshal.c:312
#25 0x282b484c in gtk_handlers_run (handlers=0x8282780, signal=0xbfbfe8e0, 
    object=0x8283060, params=0xbfbfe934, after=0) at gtksignal.c:1917
#26 0x282b3c6b in gtk_signal_real_emit (object=0x8283060, signal_id=93, 
    params=0xbfbfe934) at gtksignal.c:1477
#27 0x282b1c2b in gtk_signal_emit (object=0x8283060, signal_id=93)
    at gtksignal.c:552
#28 0x2821efb0 in gtk_button_clicked (button=0x8283060) at gtkbutton.c:338
#29 0x282206d9 in gtk_real_button_released (button=0x8283060) at gtkbutton.c:852
#30 0x28283f67 in gtk_marshal_NONE__NONE (object=0x8283060, 
    func=0x28220638 <gtk_real_button_released>, func_data=0x0, args=0xbfbfece4)
    at gtkmarshal.c:312
#31 0x282b3ae9 in gtk_signal_real_emit (object=0x8283060, signal_id=92, 
    params=0xbfbfece4) at gtksignal.c:1440
#32 0x282b1c2b in gtk_signal_emit (object=0x8283060, signal_id=92)
    at gtksignal.c:552
#33 0x2821eee4 in gtk_button_released (button=0x8283060) at gtkbutton.c:329
#34 0x28220044 in gtk_button_button_release (widget=0x8283060, event=0x8279018)
    at gtkbutton.c:712
#35 0x28283b53 in gtk_marshal_BOOL__POINTER (object=0x8283060, 
    func=0x2821ff80 <gtk_button_button_release>, func_data=0x0, args=0xbfbff0a4)
    at gtkmarshal.c:28
#36 0x282b3ca4 in gtk_signal_real_emit (object=0x8283060, signal_id=21, 
    params=0xbfbff0a4) at gtksignal.c:1492
#37 0x282b1c2b in gtk_signal_emit (object=0x8283060, signal_id=21)
    at gtksignal.c:552
#38 0x282ea9f8 in gtk_widget_event (widget=0x8283060, event=0x8279018)
    at gtkwidget.c:2860
#39 0x28283ab5 in gtk_propagate_event (widget=0x8283060, event=0x8279018)
    at gtkmain.c:1313
#40 0x28282c6a in gtk_main_do_event (event=0x8279018) at gtkmain.c:770
#41 0x2833494a in gdk_event_dispatch (source_data=0x0, current_time=0xbfbff48c, 
    user_data=0x0) at gdkevents.c:2129
#42 0x28362e7f in g_main_dispatch (dispatch_time=0xbfbff48c) at gmain.c:656
#43 0x283634ad in g_main_iterate (block=1, dispatch=1) at gmain.c:877
#44 0x28363658 in g_main_run (loop=0x826e670) at gmain.c:935
#45 0x2828250a in gtk_main () at gtkmain.c:476
#46 0x8129816 in main (argc=1, argv=0xbfbff6b8) at main.c:1370
#47 0x8060b51 in _start (arguments=0xbfbff79c "ethereal")
    at /usr/src/lib/csu/i386-elf/crt1.c:96

For those familiar with FreeBSD, /etc/malloc.conf is set to AJ:

     A       All warnings (except for the warning about unknown flags being
             set) become fatal.  The process will call abort(3) in these cas-
             es.

     J       Each byte of new memory allocated by malloc(), realloc() or
             reallocf() as well as all memory returned by free(), realloc() or
             reallocf() will be initialized to 0xd0.  This options also sets
             the ``R'' option.  This is intended for debugging and will impact
             performance negatively.

Anyone any ideas?

-- 
Jeroen Ruigrok van der Werven          VIA Net.Works The Netherlands
BSD: Technical excellence at its best  Network- and systemadministrator
	  D78D D0AD 244D 1D12 C9CA  7152 035C 1138 546A B867
Distance lends enhancement to the view...