Ethereal-dev: Re: [ethereal-dev] ICMP dissector now we have tvbuffs etc

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 11 Sep 2000 21:27:07 -0700
On Tue, Sep 12, 2000 at 03:22:54PM +0900, Richard Sharpe wrote:
> Now that we have tvbuff support, I was thinking that I should go an add
> support for dissecting the IP dg that appears as payload in some ICMP
> datagrams we see.

Unfortunately, as far as I know, that's safe only once *all* dissectors
that can be invoked when dissecting an IP datagram have been
tvbuffified, and that hasn't happened yet (heck, the IP dissector hasn't
yet been tvbuffified).

Note also that you'd probably want the ICMP dissector to call
"col_set_writable(fd, FALSE)" before calling the IP dissector, so that
ICMP packets containing the beginning of the packet that provoked the
transmission of the ICMP packet show up in the packet list as ICMP
packets, not as packets of the type of the provocative packet.