Wireshark · Ethereal-dev: Re: [ethereal-dev] [sharpe@xxxxxxxxxxxx: [ethereal-cvs] cvs commit: ethereal packet-bxxp.c]

[Guy Harris <gharris@xxxxxxxxxxxx>]

On Fri, Sep 08, 2000 at 02:37:31AM -0400, Gilbert Ramirez wrote:
> This comment in packet-bxxp.c:
> 
>   /* If we have per frame data, use that, else, we must be on the first
>    * pass, so we figure it out on the first pass.
>    *
>    * Since we can't stash info away in a conversation (as they are
>    * removed during a filter operation, and we can't rely on the visited
>    * flag, as that is set to 0 during a filter, we must save per-frame
>    * data for each frame. However, we only need it for requests. Responses
>    * are easy to manage.
>    */
> 
> is no longer true. (Remember that long thread we had...)

...and remember another item from that thread - it used to be the case
that the per-frame data pointer wasn't cleared when the per-frame data
was discarded; that bug has been fixed.

Note, though, that the per-frame data is cleared on a "redissect", which
is done if:

	a protocol is enabled or disabled;

	protocol preferences are changed.

A redissect should be thought of as being, from the point of view of the
dissectors, equivalent to closing the capture file, reopening it, and
rereading it.  "conversation_init()" and "init_all_protocols()" will be
called on a redissect.