Ethereal-dev: Re: [ethereal-dev] Visited is zero after a filter operation ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Wed, 23 Aug 2000 13:12:27 -0400
On Wed, Aug 23, 2000 at 11:01:25AM -0500, Jeff Foster wrote:
> 
> I'm for anything that will speed up the program.  I would like to hear from
> others
> about the implications of this change -
> 
> What will happen if the 'visited' flag isn't reset, and the
> conversation_init() and
> init_all_protocols() aren't called before a secondary pass through the
> packets?
> 
> Jeff Foster
> jfoste@xxxxxxxxxxxx

There's 3 callers of rescan_packets():

filter_packets()
colorize_packets()
redissect_packets()

If rescan_packets() accepted another argument, a boolean indicating
whether or not to destroy the packet state info, then redissect_packets()
and colorize_packets could say "don't destroy the data", while filter_packets()
could say "destroy the data".

Would that work?

--gilbert