Ethereal-dev: Re: [ethereal-dev] Visited is zero after a filter operation ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Wed, 23 Aug 2000 11:00:33 -0400
On Wed, Aug 23, 2000 at 08:22:52AM -0500, Jeff Foster wrote:
> 
> I feel your pain.
> 
> Can't we treat the secondary passes, to do filters, different and not reset
> the visited flag?  This has implications in the conversation coding, they
> would only be created during the first pass. It may also impact other parts
> of the program, but I leave that discussion to others that know more then
> I do. It seems to me that this would speed secondary passes up because some
> of the work doesn't have to be done for each pass, only the first pass.
> 
> Jeff Foster
> jfoste@xxxxxxxxxxxx

I made the change. Here's the CVS entry:

gram        2000/07/25 22:09:00 CDT

         Modified files:
           .                    file.c 
         Log:
         When rescanning a file, all state information for the frames has
         been deleted. So we have to set fdata->flags.visited to 0 for each frame,
         denoting a "fresh" scan.
         
         Revision  Changes    Path
         1.201     +5 -1      ethereal/file.c

In rescan_packets(), since the conversations and protocols were
being re-initialized, (with conversation_init() and init_all_protocols()),
I had to reset the visited flag.  Perhaps we need a change so that
the application of display filters won't re-initialize the already-computed
data, and thus not force a reset of the visited flag.

--gilbert