Ethereal-dev: Re: [ethereal-dev] Possible crash problem in file.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 3 Jul 2000 02:20:23 -0700
On Wed, Jun 28, 2000 at 06:43:09PM +0100, Ben Fowler wrote:
> >Unfortunately, that means the only way to abort the reading of a capture
> >file is to quit Ethereal; one might want to abort it but still have
> >Ethereal running, so that one could, say, open another file instead.
> 
> I had no intention of making this the only way of aborting a file read.
> My problem was that when one did quit ethereal is was possible for
> Bad Things (tm) to happen.

One can now, with my dialog-box changes, abort a file read by hitting
the "Cancel" button on the progress-bar dialog box popped up whilst the
file is being read - in fact, that's *all* one can do whilst the read is
in progress, as the dialog box is modal.

Currently, doing so causes Ethereal to exit; that's almost certainly not
the right thing to do if you've selected "File->Open" (as per my
comments), and I'm not even sure it's the right thing to do if you've
specified a file with the "-r" flag on the command line.

Does anybody think that if you do

	ethereal -r big_file

and hit "Cancel" in the dialog box, Ethereal should exit, rather than
closing the file and waiting for further user input?

I think I can fix the "File->Open" case without changing the "-r"-flag
case; I'll look at doing the first of those now.  Unless there's
significant support for having Ethereal exit if you cancel out of a
"-r"-flag read, I'll make it also just stop the read and leave Ethereal
running.