Ethereal-dev: Re: [ethereal-dev] initial X11 dissector close to completion, but...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Sun, 04 Jun 2000 09:57:48 -0500
On Sun, Jun 04, 2000 at 05:05:42PM +0200, Christophe Tronche wrote:
> 
> I've got a lot of header fields (about 370 of them). To keep things
> manageable, I've put them in a text file, with a short Perl script
> (very specific to my needs) to create the register info and variable
> declarations in two .h files, then #included in the packet-x11.c file
> (I remember having seen this kind of things discussed before). If I
> send a patch for that, we got two bizarre files in the distribution
> (the text file and the script), and four files for x11 (packet-x11.c,
> packet-x11.h, packet-x11-register-info.h and
> packet-x11-declarations.h), while I remember that some efforts have
> been done in the past so that only two files (packet-xxx.h and
> packet-xxx.c) were left for any protocol.

The packet-xxx.h is needed for other dissectors that call use packet-xxx.c.
It's okay if your packet-x11.c has a few other *.h files that it includes,
as long as other dissectors don't need to include the huge *.h files just
to be able to use dissect_x11().

--gilbert