Ethereal-dev: Re: [ethereal-dev] Replacing "proto_tree_add_item()" with type-specific versions
On Tue, May 30, 2000 at 06:08:23AM -0500, Guy Harris wrote:
>
>
> I have a patch to:
>
> replace almost all calls to "proto_tree_add_item()" and
> 'proto_tree_add_item_hidden()" with calls to routines adding
> items of a particular type, along the lines of what we did for
> "proto_tree_add_item_format()", with, for example,
> "proto_tree_add_uint()";
>
> rename "proto_tree_add_item()" and
> "proto_tree_add_item_hidden()" to "proto_tree_add_item_old()"
> and "proto_tree_add_item_hidden_old()" (with the intent of
> ultimately removing them);
>
> adding new "proto_tree_add_item()" and
> "proto_tree_add_item_hidden()" routines that get the value of
> the item from the tvbuff handed to them, and the offset and
> length supplied, so that you don't have to extract a value and
> then pass it to those routines.
>
> (I've mentioned this in mail in the past.)
It looks good. We need to modify plugins/plugin_table.h and friends.
I forgot to modify it along with the tvbuff changes. But it will need
even more changes after this change.
> The patch is attached; it's fairly large, as it changes most dissectors
> (Gilbert supplied a Perl script that did most of the work). Note that
> I'll be on vacation from May 31 to June 9; I may be able to check my
> mail via the Web during the latter part of the vacation.
>
> - patch
If you can, go ahead and check in the change and then I'll work on
plugin_table.h to include all necessary fixes. If you're already out the
door, though, I'll check in your huge patch.
--gilbert
