On Fri, May 12, 2000 at 01:27:46AM -0500, Ben Fowler wrote:
>
>
> Apologies for taking out of this community more than I am putting
> in; but I am investigating how the column labels are applied, and
> whilst studying the 'file.c', I noted that the symbol fd is sometimes
> used for 'file id' and sometimes for 'frame data'.
>
> The enclosed patches changes the last named to 'fdata'.
>
> I have missed one or two, 'start_fd', for instance; but the
> file is still consistent in the sense that it compiles and
> the application produces correct output; but it is tricky to get
> modifications like this on someone else's code correct.
>
> Are patches like this acceptable?
Patches that make sense are acceptable.
In this case, since the subject of 'file.c' is files, the usage
of 'fd' can be confusing, I imagine. One might argue that
since all the dissectors use 'fd' to refere to 'frame_data', then
the usage of 'int fd' in file.c should be changed. But there's
the C/Unix tradition of using 'fd' as 'file descriptor'.
Anyway, the patch makes enough sense that I'm applying it.
--gilbert
