Ethereal-dev: Re: [ethereal-dev] Not displaying values correctly

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Tue, 11 Apr 2000 11:27:39 -0500
On Tue, Apr 11, 2000 at 10:42:30AM -0500, Marc D. Behr wrote:
> 
> 
> Hi,
> 
> I am using
> ethereal 0.8.6, with GTK+ 1.2.7, with libpcap 0.4, with libz 1.1.3, without 
> SNMP
> on Linux 2.2.13 (Mandrake 6.0) to analyze some snoop output data from a 
> Solaris 2.6 system.
> 
> When I expand the TCP section, the program does not seem to display the
> flag values correctly as shown below. Shouldn't the ACK line show a 1 
> rather
> than a 0?

Yes, thanks. We have discovered that bug and I'm checking in a fix now.
The following patch should fix it for you.

--gilbert
Index: proto.c
===================================================================
RCS file: /usr/local/cvsroot/ethereal/proto.c,v
retrieving revision 1.60
diff -u -r1.60 proto.c
--- proto.c	2000/04/04 17:07:07	1.60
+++ proto.c	2000/04/11 16:04:38
@@ -738,7 +738,7 @@
 static void
 proto_tree_set_boolean(field_info *fi, guint32  value)
 {
-	fi->value.numeric = value;
+	proto_tree_set_uint(fi, value);
 }
 
 /* Add a FT_DOUBLE to a proto_tree */