Ethereal-dev: Re: [ethereal-dev] bug in latest packet_ldap.c (CVS 1.4)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: nazard@xxxxxxxxxxxxxxx
Date: Mon, 3 Apr 2000 04:37:57 -0400 (EDT)
On  3 Apr, Guy Harris wrote:
>> Damn. Went to post the fix and just received your message. <sigh>
> 
> I checked in those of your fixes that still apply to the code after my
> changes (putting the error indications under the top-level item in the
> LDAP tree, adding an "exit right after filling in the columns if we're
> not building a protocol tree" check), and got rid of my change that did
> an "exit after the first request" as one of your changes obviates the
> need for it.

Found another bug. I really got to stop cutting and pasting at 5am
<sigh>

On another note, any reason ethereal doesn't support writing gzip'd
files? I was looking at adding bzip2 support. There also appear to be
a lot of opens and closes.

-- 
Doug Nazar
Dragon Computer Consultants Inc.
Tel: (416) 708-1578     Fax: (416) 708-8081

Index: packet-ldap.c
===================================================================
RCS file: /cvsroot/ethereal/packet-ldap.c,v
retrieving revision 1.5
diff -u -w -r1.5 packet-ldap.c
--- packet-ldap.c	2000/03/31 10:22:24	1.5
+++ packet-ldap.c	2000/04/03 08:35:17
@@ -398,7 +398,7 @@
         ret = asn1_octet_string_value_decode(a, length, &string);
         if (ret != ASN1_ERR_NOERROR)
           return ret;
-        *filter_length += 3 + length;
+        *filter_length += 4 + length;
         *filter = g_realloc(*filter, *filter_length);
         sprintf(*filter + strlen(*filter), "(%.*s=*)", (int)length, string);
         g_free(string);