Ethereal-dev: RE: [ethereal-dev] Wish-List item #32

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Paul D. Walker" <pdwalker@xxxxxxxxxxxx>
Date: Sun, 5 Mar 2000 11:36:06 +0800
Hmmmm, I thought that was too easy.  Ok, something worth fixing then.

1/ I'll find out why "select packet" does not grab the correct entry

2/ The gtk_clist_sort function appears to be doing only a string sort.
Therefore 1,10,11...2,20.. appears to be the proper order.  A more
intelligent way to handle it will be to look for this column and do a
numeric sort only on this column.

An alternative would be to pad the Number column with leading 0's.

Sorting on the absolute time will work as long as the time does not
cross the 23:59 / 0:00 boundary.

ok, I'll work on it.

- Paul
pdwalker@xxxxxxxxxxxx

-----Original Message-----
From: Gilbert Ramirez [mailto:gram@xxxxxxxxxx]
Sent: Sunday, March 05, 2000 10:48 AM
To: Paul D. Walker
Cc: ethereal-dev@xxxxxxxx
Subject: Re: [ethereal-dev] Wish-List item #32

Thanks.  There's a couple of problems with it, though.

Our "select_packet" routine in file.c, which is called when
a packet is selected in the CList, is picking up the wrong packet
and thus displaying the wrong info in the decode tree. It's using
the CList row regardless of what number packet is in that row.

Interestingly, the "Show packet in new window" function _does_
work correctly, even if the decode tree is incorrect.

Also, there's no way to return the CList to its original order.
Sorting on the "No." column won't work, since "10" gets sorted before
"2". And since the columns that a user sees are user-configurable,
it is possible (although highly unprobably) that a user could
have no "No." column at all. (Really, in that case, the user gets
what he deserves.)

--gilbert

On Sun, Mar 05, 2000 at 12:04:43PM +0800, Paul D. Walker wrote:
> Hi Guys,
>
> This small patch allows you to sort the contents of the packet
window by
> clicking on the appropriate header.
>
> If you like it, you can include it.  Oh, the comment sucks.  It's
4am and it
> seemed ok an hour ago.
>
>  - Paul
> pdwalker@xxxxxxxxxxxx