Ethereal-dev: Re: [ethereal-dev] Ethereal crash

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Fri, 11 Feb 2000 20:07:06 -0800
> 	if ( ServerType & (1 << (i-1)) && (strcmp("Unused", svr_types[i] != 0))

	if ( ServerType & (1 << (i-1)) && (strcmp("Unused", svr_types[i-1] != 0))

might work better, given that C array indices are 0-origin, and "i"
starts at 1.

      for (i = 0; i < 32; i++) {

	if (ServerType & (1 << i) && (strcmp("Unused", svr_types[i]) != 0))
	    col_append_fstr(fd, COL_INFO, ", %s", svr_types[i]);
	
      }

would perhaps work even better.