Ethereal-dev: Re: [ethereal-dev] zlib support issue

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Mon, 24 Jan 2000 10:49:37 -0800
> 	On NetBSD 1.4.1, ethereal zlib support needs to be disabled to
> 	make it function properly.  This is because:
> 	- /usr/include/zconf.h includes the following clause,
> 	- libz.a is compiled with z_off_t == long,
> 	- and ethreal uses z_off_t = off_t (due to HAVE_UNISTD_H).

Ethereal *itself* doesn't use "gzseek()" at all; only Wiretap uses it,
and, in the version in the CVS tree, the only code in Wiretap that uses
it is the "file_seek()" routine in "file_wrappers.c", and HAVE_UNISTD_H
is forcibly undefined by "file_wrappers.c" after "config.h" is included
and before any other header files are included - and no header files in
the Wiretap directory include "config.h".

How, then, in the code in the CVS tree, does HAVE_UNISTD_H have any
effect whatsoever on the declaration of "gzseek()" in "file_wrappers.c"?

Note that the behavior you describe on NetBSD 1.4.1 also applies to
FreeBSD 3.3, and the code in the CVS tree works fine in FreeBSD 3.3 when
built with zlib.

> 	I find it easier to disable zlib on such platform.

No, that's a gross workaround - we should *make Ethereal work with zlib*
on those platforms.  I do *NOT* want zlib disabled on my FreeBSD
machine....