Ethereal-dev: [ethereal-dev] pptp error?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Gilbert Ramirez <gram@xxxxxxxxxx>
Date: Wed, 19 Jan 2000 09:09:36 -0600
The maintainer of the Debian package of Ethereal forwarded
the following bug report to me:

http://cgi.debian.org/cgi-bin/bugreport.cgi?bug=55347

The summary is:


Package: ethereal
Version: 0.8.0-1
Severity: normal

All data in PPTP packets is in network order (big-endian).
The current PPTP decoder in ethereal lacks the proper ntoh* calls
to correctly decode them. The included patch is a proposed solution.

Also, please note that a new upstream release (0.8.1) is out.
The patch is suitable for both 0.8.0 and 0.8.1. Can you
please forward it to the upstream maintainers?

Thanks for your help,
Thomas.

The diff is on the web page.


Not knowing PPTP, I have to ask, does this change look valid?

--gilbert