Wireshark · Ethereal-dev: Re: [ethereal-dev] minor problems with RPC dissector

[Guy Harris <guy@xxxxxxxxxx>]

> For some reason, it doesn't seem to be detecting alot of the "Reply"
> packets.

Duh!  My conversation-comparison code wasn't checking if the two packets
were going in opposite directions in the same conversation if *any* of
the tests that checked if they were going in the same direction in the
same conversation, only if the check of the addresses failed.

That worked if the two addresses were different, but not if they're the
same, as is the case if it's a conversation between two processes on the
same machine....

I've checked in a fix, and it now recognizes the reply packets.

(The motivation for treating the address test as a sure-fire indication
of the direction of the packet was to avoid extra tests; perhaps testing
the ports first would achieve the same goal - testing ports is cheaper,
as they're just integers, and there's probably a decent chance that you
won't see two conversations between different pairs of hosts and the
*same* pair of ports in a capture file.)