Ethereal-dev: [ethereal-dev] changes just committed to cvs

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Neulinger, Nathan R." <nneul@xxxxxxx>
Date: Thu, 11 Nov 1999 10:25:52 -0600
I wanted to send this to ethereal-dev as well as ethereal-cvs, 
since I edited a couple other authors files here:

      Added proto_registrar_get_name routine to proto.c to retrieve the name
        of particular proto_tree field.

I just copied proto_registrat_get_abbrev for that one, seemed in
style/scheme with 
the other routines, so didn't think anyone would object. This was added so
that I
could implement the dissect_rpc_string_item routine. 

      Added dissect_rpc_string_item to packet-rpc.c. This routine does the
same
        thing as dissect_rpc_string, except it takes a hfindex of a       
        proto_tree item instead of a name. It uses the p_r_get_name call
        to get the name, and adds the actual string content as a hidden
        field (so that the subtree highlights the entire data area - length,
        data, and padding). There is only one call to dissect_rpc_string, so

        I believe that this routine should replace it.

I suppose that could be collapsed down to a single field, but then what is
highlighted would be what is matched, so didn't think that was right. Not
sure. Feel free to change this around.  I added this routine cause I didn't
want to go changing someone else's routines, but I don't see much reason to
keep the other one around as it is only used in one place. 

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@xxxxxxx
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216