Ethereal-dev: Re: [ethereal-dev] Decoding IP within other protos

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 6 Oct 1999 10:03:27 -0700 (PDT)
> I wanted to see the IP header that is inside an ICMP dest unreachable, so I
> modified dissect_icmp to call dissect_ip so that I can see this info.
> 
> I am not sure how useful this will be, but it seems to work OK.

I had a version that did that...

...but I haven't checked it in, because I seem to remember it dropping
core when dissecting something such as a Port Unreachable reply to a DNS
or NBNS packet.

I think the problem was that the DNS or NBNS dissector wasn't doing
enough bounds checking, and probably did something such as trying to
dissect a DNS or NBNS name, ran off the end of the packet into a pile of
garbage, and blew up trying to dissect it.