Ethereal-dev: [ethereal-dev] Small patch: off-by-one obfuscates SAP reply in list pane

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Mark H. Wood" <mwood@xxxxxxxxx>
Date: Wed, 15 Sep 1999 16:59:04 -0500 (EST)
I just found Ethereal.  I really like it.  However I almost immediately
found that SAP replies were shown as "unknown" in the list pane's Info
column.  Patch attached.  Share and enjoy.

-- 
Mark H. Wood, Lead System Programmer   mwood@xxxxxxxxx
A Brazil-nut is neatly packaged and tightly integrated.  To turn it into
food, you must crack and remove the shell.  I find that I feel the same   
way about an increasing number of software products.  *sigh*

*** packet-ipx.c.orig	Wed Sep 15 15:39:15 1999
--- packet-ipx.c	Wed Sep 15 15:40:26 1999
***************
*** 530,536 ****
  	if (check_col(fd, COL_PROTOCOL))
  		col_add_str(fd, COL_PROTOCOL, "SAP");
  	if (check_col(fd, COL_INFO)) {
! 		if (query.query_type < 4) {
  			col_add_str(fd, COL_INFO, sap_type[query.query_type - 1]);
  		}
  		else {
--- 530,536 ----
  	if (check_col(fd, COL_PROTOCOL))
  		col_add_str(fd, COL_PROTOCOL, "SAP");
  	if (check_col(fd, COL_INFO)) {
! 		if (query.query_type <= 4) {
  			col_add_str(fd, COL_INFO, sap_type[query.query_type - 1]);
  		}
  		else {