Ethereal-dev: Re: [ethereal-dev] packet-netbios bug

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Tue, 24 Aug 1999 17:00:57 -0700 (PDT)
> Having put some code in to at least put some information in for the
> "unknown" types of TLV entries, it looks as if the CDP analyzer may be
> running past the end of the packet or something - it seems to think
> there's a TLV entry at the end with a type of 256 and a length of 0, but
> the entry right before it runs all the way up to the last octet in the
> frame.
> 
> I'll look into that.

Yup, the CDP code wasn't correctly checking for the end of the packet -
it was checking whether the offset was <= the (captured) size of the
frame, rather than < the size of the frame.

I'll check in a fix (plus my other changes).