On Mon, Aug 23, 1999 at 04:55:20PM -0500, Guy Harris wrote:
>
>
> > In source from cvs 30 min ago, i needed the following patch to make
> > ethereal build on OSF/1 (Digital Unix/Tru64)..
>
> In the current tree, "swap_mac_addr()" is just like "get_mac_addr()",
> except that it bit-swaps the MAC address regardless of whether
> BIT_SWAPPED_MAC_ADDRS is defined or not; the comment before the stuff
> that uses the result of "swap_mac_addr()" is
>
> /* hide some bit-swapped mac address fields in the proto_tree, just in case
> */
>
> which suggest that it's intended to do so.
>
> If so, then the fix would be to have "swaptab[]" be defined regardless
> of whether BIT_SWAPPED_MAC_ADDRS is defined or not.
>
> Gilbert, is that what you intended?
Yes, so that the addresses could be filterable objects even if they were
swapped and we didn't know that the OS/NIC driver had the opposite
swapping:
/* hide some bit-swapped mac address fields in the proto_tree, just in case */
proto_tree_add_item_hidden(fh_tree, hf_fddi_dst, FDDI_P_DHOST, 6, dst_swapped);
proto_tree_add_item_hidden(fh_tree, hf_fddi_dst, FDDI_P_SHOST, 6, src_swapped);
I'll make the change and check it in.
thanks,
--gilbert
