Ethereal-dev: Re: [ethereal-dev] CLIP patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jeff Jahr <jjahr@xxxxxxxxxxxxxx>
Date: Wed, 28 Jul 1999 12:29:15 -0700 (PDT)

On Wed, 28 Jul 1999, Gilbert Ramirez wrote:

> I see nothing wrong in making all dissect() functions take 4 arguments.
> dissect_packet() will simple pass 0 as the offset to the "top-level"
> dissectors. Would this simplify your pppoe decoder?

Eh.. it would help remove some redundant code.  I ended up copying the
dissect_ppp code into dissect_payload_ppp where I added the fourth
argument and removed decoding of what I presumed was a serial link header.  
The two functions could be consolidated back into one.

I'm for Making a global change to four argument dissectors.  It would help
simplify the writing of new dissectors that decode encapsulated top-level
protocols, like pppoe or gre or 'linux style clip'.  I dont have a
pressing need for the change right now, but it might prove useful to
someone in the future.

-jsj