Ethereal-dev: Re: [ethereal-dev] Code for ISAKMP, GRE, and PPTP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jeff Jahr <jjahr@xxxxxxxxxxxxxx>
Date: Fri, 11 Jun 1999 10:25:45 -0700 (PDT)

On Thu, 10 Jun 1999, Gilbert Ramirez wrote:

> In packet-pppoe.c, why do "  String Data" and "  Binary Data" have spaces
> at the beginning? Are you indenting on purpose? Or do you mean to have
> these be sub-items of another item, say the Tag item?

I indented on purpose to show that the displayed data (be it of type
binary or string) is associated with the preceeding Tag, despite the fact
that the item was not added as a sub-item of the Tag.  

Hindsight being what it is, I see that I probably should have added the
data decode as a sub-item of the Tag.  ;')

-jsj