On Fri, 4 Jun 1999, Brad Robel-Forrest wrote:
> I apologize for this newbie question, but I've added parsing code for
> PPTP, GRE, and ISAKMP and would like to contribute my changes. Is there
> anything special I need to do before I cvs commit my changes (e.g. does
> the code need to be reviewed by anyone or do I need to obtain an account
> somewhere)?
I hate to post a 'me too', but...
> I am also planning on making some changes to the PPP parsing logic (like
> adding code to display the LCP, IPCP, CHAP, and other negotiations as well
> as modifying it to use offsets so that it may be called to parse the
> information that could be contained in a GRE packet). Any steps here I
> need to take so that my changes do not step on anyone's toes?
I added these exact changes to support PPPoE decoding. I dont parse all
of the LCP, IPCP, etc. options yet, but it wouldnt be too hard for someone
to add them in once my changes are somewhere other than just my local
fileserver.
I did use cvs to pull down my copy of the source, but having never used
cvs before that, I have no idea how to send my changes back. Could
someone point us newbies to the 'submission instructions' page?
Thanks! -jsj
