Ethereal-dev: [ethereal-dev] IP TOS Bug !!!

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Hannes R. Boehm" <hannes@xxxxxxxxx>
Date: Tue, 30 Mar 1999 19:35:44 +0200

Aaaaaaaaaaaaaaaaaaaaahhhhhhhhhhhhhhhhhhhhh!!!!

I did real network debugging with ethereal,
but I could not find the error for hours :(

The problem:

Ethereal did erase the ip precedence Bits :

--- packet-ip.c 1999/03/23 03:14:38     1.18
+++ packet-ip.c 1999/03/30 15:22:11
@@ -600,8 +600,8 @@
   if (check_col(fd, COL_UNRES_NET_DST))
     col_add_str(fd, COL_UNRES_NET_DST, ip_to_str((guint8 *) &iph.ip_dst));

-  iph.ip_tos = IPTOS_TOS(iph.ip_tos);
-  switch (iph.ip_tos) {
+  /* iph.ip_tos = IPTOS_TOS(iph.ip_tos); */
+  switch (IPTOS_TOS(iph.ip_tos)) {
     case IPTOS_NONE:
       strcpy(tos_str, "None");
       break;                                                   


Maybe there is a better fix ?
(the comment line can be removed of course :)

wkr

Hannes


-- 
--
"The nice thing about standards is that there's so many to choose from." 
        -- Andrew S. Tanenbaum
!------------------------------------------------------------------!
  Hannes R. Boehm
        email   : hannes@xxxxxxxxx
        www     : http://hannes.boehm.org
        PGP-key : http://hannes.boehm.org/hannes-pgp.asc
!------------------------------------------------------------------!