Ethereal-cvs: [Ethereal-cvs] rev 17636: /trunk/epan/dissectors/: ncp2222.py packet-ncp-int.h p

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: etxrab@xxxxxxxxxxxx
Date: Wed, 15 Mar 2006 18:56:38 GMT
User: etxrab
Date: 2006/03/15 12:56 PM

Log:
 From Greg Morris:
 
 Modification to (proto.h) is made to add an additional expert group type of PI_REQUEST_CODE to allow Request tag information to be passed to the expert tap. This is for such reasons where a dissector would like to echo specific information about certain types of requests. For example: NCP connection request is really a request not a REPLY_CODE. Same is true for the TCP SYN request.
 
 Changes to packet-ncp.c
 1. Server broadcast message flag. Now indicates if the message is a pending message or an oplock clear notification.
 2. Cleanup of packet signature detection process. Previous method had some flaws so I redesigned it. Appears to be solid now.
 3. Echo NCP Server Session information to expert tap.
  
 Note on item #3: NCP Connection+Task = NCP Session, a Single connection can have many tasks. The server sees each connection/task as a unique session. For this reason the NCP session information is now echoed to the expert composite statistics so that you can easily identify the different NCP processes and sessions. It is important to NCP analysis to understand that each session is most likely a different program on the requesting host sharing the same NCP connection.
  
 Changes to packet-ncp2222.inc
 1. Comment out the echo of NCP connection info to expert tap. Replaced by NCP sessions.
 2. Add displayEID in request decode (resolves Coverity defect for dead code in NCP dissector)
  
 Changes to ncp2222.py
 1. Fix for endian display of bindery object type in NCP 0x1720.
 2. Fix for size of bindery object type to 2 bytes instead of 4 to match other bindery NCP's.

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +7 -6      ncp2222.py          Modified
  +1 -0      packet-ncp-int.h    Modified
  +172 -171  packet-ncp.c        Modified

Directory: /trunk/epan/
  Changes    Path          Action
  +2 -0      proto.h       Modified

Directory: /trunk/gtk/
  Changes    Path            Action
  +1 -0      expert_dlg.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=17636&view=rev