Ethereal-cvs: [Ethereal-cvs] rev 15807: /trunk/epan/dissectors/: packet-lldp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Thu, 15 Sep 2005 03:09:41 GMT
User: guy
Date: 2005/09/14 10:09 PM

Log:
 Properly handle 64-bit integer constants (they don't happen by magic,
 and the stuff you have to do is compiler-dependent, so use
 G_GINT64_CONSTANT()).
 
 Properly handle formatting 64-bit quantities (they don't format
 correctly by magic, and the stuff you have to do is compiler-dependent,
 so use PRI[duoxX]64).
 
 Don't copy the result of tvb_bytes_to_str() to a string buffer and then
 only use it as an argument to a "%s" - just use the result directly. 
 
 Don't copy constant strings to a buffer - just use the strings directly.
 
 Fetch 64-bit integral quantities with tvb_get_ntoh64(); they're
 presumably in a standard byte order, which is probably big-endian for
 Internet-family protocols, and using tvb_memcpy() is *guaranteed* to be
 wrong on some platforms.
 
 Fix up a format string.
 
 Fix up indentation a bit.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +23 -23    packet-lldp.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=15807&view=rev