Ethereal-cvs: [Ethereal-cvs] rev 15057: /trunk/epan/: reassemble.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Mon, 25 Jul 2005 18:03:21 GMT
User: guy
Date: 2005/07/25 01:03 PM

Log:
 When reassembling a packet, all data, including data with
 FD_NOT_MALLOCED set, has to be copied - all FD_NOT_MALLOCED means is
 that the fragment's data is part of the old reassembled data, rather
 than a malloced chunk of its own (this happens if, after reassembly, the
 dissector says more reassembly is necessary, as can happen, for example,
 in the case of HTTP and other protocols where reassembly continues until
 a terminator is seen).  Not copying the data means that the reassembled
 data is, in part, whatever random junk happens to be in the
 newly-allocated buffer.
 
 Back out the change not to copy the data, but add some sanity checks, in
 the hopes of preventing the crash that caused the change not to copy the
 data to be added, and in the hopes of discovering the ultimate source of
 that crash and fixing it.

Directory: /trunk/epan/
  Changes    Path            Action
  +41 -14    reassemble.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=15057&view=rev