Ethereal-cvs: [Ethereal-cvs] rev 14874: /trunk/epan/dissectors/: packet-actrace.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Fri, 08 Jul 2005 02:31:47 GMT
User: guy
Date: 2005/07/07 09:31 PM

Log:
 Get rid of most unused arguments and variables (including some that are
 set but not used).  (Leave "pi" around so the warning acts as a reminder
 that the tap structure stuff needs a cleanup - currently, the tap
 structures aren't freed; perhaps the new memory allocation scheme
 proposed by Ronnie could be used for tap structures.)
 
 Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace
 packets and return the packet type for actrace packets, so that we don't
 need a global variable for the packet type.
 
 Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned
 warning.
 
 Use "col_set_str()" rather than "col_add_str()" when setting the
 Protocol column.
 
 We don't recognized packets as CAS packets unless they're 48 bytes long,
 so we don't need to test whether they're 48 bytes long in the CAS packet
 dissection code.
 
 Use the reported length, not the captured length, when doing length
 checks.

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +32 -48    packet-actrace.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14874&view=rev