Ethereal-cvs: [Ethereal-cvs] rev 14793: /trunk/epan/dissectors/: packet-dns.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Mon, 27 Jun 2005 07:50:19 -0000
User: guy
Date: 2005/06/27 02:50 AM

Log:
 The name returned by "get_dns_name()" (and thus by
 "get_dns_name_type_class()") is null-terminated - and the length
 returned is *NOT* the length of the string, it's the length of the chunk
 of DNS data extracted by "get_dns_name()", and that chunk could just
 point to a later chunk as part of DNS compression.  When running the
 name through "format_text()", just use "strlen()" to get the length, so
 you don't get a value that's too large *OR* too small (both are
 possible - "too large" if it's uncompressed and includes length
 informatioin, "too small" if it contains a pointer to a string longer
 than the pointer).
 
 When adding a string value to the protocol tree, add the *raw* name, not
 the formatted name - the Ethereal display code will format the string's
 value as necessary.
 
 Add formatting code for DNS names in replies.

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +72 -52    packet-dns.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14793&view=rev