Wireshark · Ethereal-cvs: [Ethereal-cvs] rev 14608: /trunk/epan/dissectors/: packet-bittorrent.c packet-bssgp.c packet-cops.c

[ulfl@xxxxxxxxxxxx]

User: ulfl
Date: 2005/06/10 01:28 PM

Log:
 just to get things straight: a dissector should *never* do any g_assert() calls!
 
 in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED()
 
 this will replace application crash by showing a dissector bug, which is the desired behaviour
 
 there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too
 
 one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain.

Directory: /trunk/epan/dissectors/
  Changes    Path                   Action
  +1 -1      packet-bittorrent.c    Modified
  +7 -7      packet-bssgp.c         Modified
  +1 -1      packet-cops.c          Modified
  +1 -2      packet-dcerpc.c        Modified
  +1 -1      packet-dcm.c           Modified
  +1 -1      packet-dns.c           Modified
  +1 -1      packet-esis.c          Modified
  +1 -1      packet-gsm_sms_ud.c    Modified
  +5 -5      packet-iax2.c          Modified
  +1 -1      packet-iscsi.c         Modified
  +5 -5      packet-jxta.c          Modified
  +8 -8      packet-ldap.c          Modified
  +2 -2      packet-msdp.c          Modified
  +1 -1      packet-msproxy.c       Modified
  +2 -2      packet-mtp3.c          Modified
  +5 -5      packet-ncp2222.inc     Modified
  +1 -1      packet-ospf.c          Modified
  +1 -1      packet-pim.c           Modified
  +1 -1      packet-ppp.c           Modified
  +2 -2      packet-pppoe.c         Modified
  +3 -3      packet-radius.c        Modified
  +7 -7      packet-rpc.c           Modified
  +1 -1      packet-rtsp.c          Modified
  +3 -3      packet-smb-pipe.c      Modified
  +1 -1      packet-smpp.c          Modified
  +1 -1      packet-sna.c           Modified
  +1 -1      packet-snmp.c          Modified
  +2 -2      packet-socks.c         Modified
  +1 -1      packet-tcp.c           Modified
  +2 -2      packet-udp.c           Modified
  +1 -1      packet-vj.c            Modified
  +1 -1      packet-wbxml.c         Modified
  +1 -1      packet-wcp.c           Modified
  +2 -2      packet-x11.c           Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14608&view=rev