Ethereal-cvs: [Ethereal-cvs] rev 14269: /trunk/gtk/: voip_calls.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: gerald@xxxxxxxxxxxx
Date: Mon, 02 May 2005 14:45:52 -0000
User: gerald
Date: 2005/05/02 09:45 AM

Log:
 From Cvetan Ivanov:
 
 This patch fixes the slightly broken logic in the loop which searches
 for establisted call in isup_calls_packet.
 
 The problem is that (right_pair) is set to false if we see call on the
 same CIC as existing conversation, but with different opc/dpc pair:
 
 at this point dpc/opc pair is not checked, so any call with the same
 CIC matches:
 
 voip_call.c:851
                                  else{
                                          right_pair = FALSE;
                                  }
 
 and then the correct conversation is never found, because right_pair is
 never reset for this packet, which leads to total confusion of the call
 tracking logic
 
 Fixed by initializing right_pair = TRUE for every loop iteration

Directory: /trunk/gtk/
  Changes    Path            Action
  +2 -1      voip_calls.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14269&view=rev