Ethereal-cvs: [Ethereal-cvs] rev 14009: /trunk/epan/dissectors/: packet-ncp2222.inc

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: sahlberg@xxxxxxxxxxxx
Date: Mon, 04 Apr 2005 04:14:51 -0000
User: sahlberg
Date: 2005/04/03 11:14 PM

Log:
 the netware dissector is the only dissector that accesses fvalue_ functions directly.
 
 this made it crash for some packets when the filter speedup patch was enabled, since some of these finfo nodes did no longer exist.
 
 as far as i can tell the only other instances of fvalue_ usage is from some tap based functions but all those do take care to make sure that the fields being accessed are all part of a filter, and will thus never be optimized away.
 
 The patch does two things
 
 1, refactor the code but do not change the logic to reduce the number of places where the external fvalue_ functions are called from.
 
 2, add code to force the tree to be visible (and thus change the code) so that the speedup patch will not optimize these fiuelds away.

Directory: /trunk/epan/dissectors/
  Changes    Path                  Action
  +68 -13    packet-ncp2222.inc    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14009&view=rev