Ethereal-cvs: [Ethereal-cvs] rev 13707: /trunk/epan/dissectors/: packet-iapp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Fri, 11 Mar 2005 01:35:12 -0000
User: guy
Date: 2005/03/10 07:35 PM

Log:
 Just use "tvb_format_text()" to handle strings - don't roll our own
 routine to handle that.
  
 Don't format the value text into a buffer; just use
 "proto_item_append_text()", so we don't run the risk of overflowing the
 buffer.
 
 Use "ip_to_str()" to format an IP address - don't roll our own code to
 handle that.
 
 Don't make "is_fhss" global - that causes its value to depend on the
 last packet dissected, which isn't necessarily the right value for the
 packet being dissected.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +48 -88    packet-iapp.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=13707&view=rev