Ethereal-cvs: [Ethereal-cvs] rev 12971: /trunk/epan/dissectors/: packet-slsk.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date: Fri, 07 Jan 2005 10:09:45 -0000
User: guy
Date: 2005/01/07 04:09 AM

Log:
 From Chris Maynard: free strings fetched with "tvb_get_string()".
 
 Use "format_text()" or "tvb_format_text()" with the %s format, to handle
 non-printable characters.
 
 When uncompressing data into a new tvbuff, add it to the list of data
 sources as we do elsewhere.
 
 When putting items into the protocol tree from an uncompressed tvbuff,
 use the offset into the tvbuff and the length of the item.
 
 Fetch string lengths into a variable and use the variable rather than
 repeatedly fetching the length from a tvbuff.
 
 Use -1 rather than tvb_length_remaining() when putting a "to the end of
 the tvbuff" item into the protocol tree.
 
 Use "proto_tree_add_item()" to put items into the tree, rather than
 "proto_tree_add_xxx" calls with a "tvb_get_yyy" call as the argument.
 
 If we've fetched a value into a variable, don't re-fetch it in
 "proto_tree_add_xxx" calls.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +333 -184  packet-slsk.c    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=12971&view=rev