Ethereal-cvs: [Ethereal-cvs] rev 12905: /trunk/epan/dissectors/: packet-fcswils.c packet-fcswi

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx
Date: Fri, 31 Dec 2004 20:58:32 -0000
User: guy
Date: 2004/12/31 02:58 PM

Log:
 Note what Fibre Channel spec documents this protocol.
 
 Don't assign the const pointers passed to hash routines to non-const
 pointers.
 
 Don't use "tvb_get_ptr()" to get a pointer to a data structure, and
 dereference that pointer - there's no guarantee that the structure in
 question will be located on an appropriate boundary in the data from the
 packet (regardless of whether it's properly aligned within the data for
 the protocol being dissected).
 
 Put the record length for an EFP request into the protocol tree.
 
 Check the sanity of the payload length for that request.
 
 In "zonenm_to_str()", don't assume there's a null terminator in the
 packet - use "tvb_get_string()" so that the buffer into which it's
 copied is explicitly null-terminated.
 
 Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string,
 rather than as a string with one blank in it.

Directory: /trunk/epan/dissectors/
  Changes    Path                Action
  +100 -73   packet-fcswils.c    Modified
  +1 -2      packet-fcswils.h    Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=12905&view=rev