Wireshark · Ethereal-cvs: [Ethereal-cvs] rev 12881: /trunk/epan/: filesystem.c filesystem.h /trunk/gtk/: about_dlg.c dcerpc_st

[guy@xxxxxxxxxxxx]

User: guy
Date: 2004/12/30 06:26 PM

Log:
 "gtk_entry_get_text()" returns a "const char *" - assign the result to
 one.
 
 "get_basename()" doesn't modify its argument, and its callers don't
 modify the substring pointed to by the result, so make it take a "const
 char *" as an argument and return a "const char *". 
 
 "find_last_pathname_separator()" doesn't modify its argument, so make it
 a "const char *" - but some of its callers pass a non-"const" "char *"
 and modify the result, so don't make its return value a "const char *".
 And, as none of its callers are outside "filesystem.c", make it static.
 
 In "about_folders_page_new()", have separate variables for pathnames
 returned as "const char *" (which are cached by the routine that returns
 them, so you can't modify them - and can't free them, so get rid of the
 commented-out "g_free()" calls for them) and pathnames returned as "char
 *" (which are allocated anew for each call, and can be modified, but
 have to be freed).
 
 Clean up white space.

Directory: /trunk/epan/
  Changes    Path            Action
  +6 -6      filesystem.c    Modified
  +1 -8      filesystem.h    Modified

Directory: /trunk/gtk/
  Changes    Path                 Action
  +7 -9      about_dlg.c          Modified
  +2 -2      dcerpc_stat.c        Modified
  +2 -2      fc_stat.c            Modified
  +17 -15    file_dlg.c           Modified
  +5 -5      io_stat.c            Modified
  +2 -2      ldap_stat.c          Modified
  +1 -1      main.c               Modified
  +2 -2      rpc_stat.c           Modified
  +2 -2      smb_stat.c           Modified
  +3 -3      tap_dfilter_dlg.c    Modified

Directory: /trunk/
  Changes    Path          Action
  +28 -26    file.c        Modified
  +1 -1      file.h        Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=12881&view=rev