Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-bacnet.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx (Guy Harris)
Date: Wed, 12 May 2004 14:55:14 -0500 (CDT)
guy         2004/05/12 14:55:14 CDT

  Modified files:
    .                    packet-bacnet.c 
  Log:
  Make the calls to build the protocol tree regardless of whether we're
  building one or not - we have to do some of that work anyway, so we know
  the offset of the payload and so that we call sub-dissectors, and the
  easiest way to do that is to do all the work (you make more procedure
  calls that way than you'd like, but the procedures at least return
  quickly when they find they've been passed a null pointer; hopefully
  that won't add too much CPU time to dissection of BACNET traces on the
  first pass).
  
  Don't use "proto_tree_add_uint_format()" in a case where it's not
  necessary - and fix the field being used not to have a bitmask, as it's
  not a bitfield.
  
  Revision  Changes    Path
  1.18      +164 -170  ethereal/packet-bacnet.c