Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-ethertype.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: guy@xxxxxxxxxxxx (Guy Harris)
Date: Wed, 28 Jan 2004 14:09:44 -0600 (CST)
guy         2004/01/28 14:09:44 CST

  Modified files:
    .                    packet-ethertype.c 
  Log:
  If we don't have any of the packet padding in the tvbuff, don't even try
  to add the trailer - that avoids the problem with throwing an exception
  inside a CATCH* clause for that same exception.  (XXX - is this a
  problem with our exception mechanism? What happens in languages with
  built-in exceptions if a
  
  	try
  		XXX
  	catch YYY
  		ZZZ
  	end
  
  construct throws exception YYY inside code block ZZZ?  If it doesn't
  re-enter ZZZ, that argues that our exception mechanism is buggy or, at
  least, violates the Principle of Least Surprise.)
  
  Move the code to put the trailer information into the protocol tree out
  of the CATCH2 clause, so the trailer shows up if we *do* have the
  trailer information.
  
  Revision  Changes    Path
  1.43      +12 -9     ethereal/packet-ethertype.c