Wireshark · Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal/gtk file_dlg.c main.c menu.c rtp_analysis.c tcp_graph.c

[guy@xxxxxxxxxxxx (Guy Harris)]

guy         2004/01/25 15:55:11 CST

  Modified files:
    gtk                  file_dlg.c main.c menu.c rtp_analysis.c 
                         tcp_graph.c 
  Log:
  Have the Wiretap open, read, and seek-and-read routines return, in
  addition to an error code, an error info string, for
  WTAP_ERR_UNSUPPORTED, WTAP_ERR_UNSUPPORTED_ENCAP, and
  WTAP_ERR_BAD_RECORD errors.  Replace the error messages logged with
  "g_message()" for those errors with g_strdup()ed or g_strdup_printf()ed
  strings returned as the error info string, and change the callers of
  those routines to, for those errors, put the info string into the
  printed message or alert box for the error.
  
  Add messages for cases where those errors were returned without printing
  an additional message.
  
  Nobody uses the error code from "cf_read()" - "cf_read()" puts up the
  alert box itself for failures; get rid of the error code, so it just
  returns a success/failure indication.
  
  Rename "file_read_error_message()" to "cf_read_error_message()", as it
  handles read errors from Wiretap, and have it take an error info string
  as an argument.  (That handles a lot of the work of putting the info
  string into the error message.)
  
  Make some variables in "ascend-grammar.y" static.
  
  Check the return value of "erf_read_header()" in "erf_seek_read()".
  
  Get rid of an unused #define in "i4btrace.c".
  
  Revision  Changes    Path
  1.84      +3 -4      ethereal/gtk/file_dlg.c
  1.375     +5 -4      ethereal/gtk/main.c
  1.147     +4 -5      ethereal/gtk/menu.c
  1.27      +5 -3      ethereal/gtk/rtp_analysis.c
  1.47      +5 -4      ethereal/gtk/tcp_graph.c