Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-x11-keysymdef.h packet-x11.c x11-fiel

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: guy@xxxxxxxxxxxx (Guy Harris)
Date: Sun, 4 Jan 2004 04:57:18 -0600 (CST)
guy         2004/01/04 04:57:18 CST

  Modified files:
    .                    packet-x11-keysymdef.h packet-x11.c 
                         x11-fields 
  Log:
  Move "XConvertCase()" from a header file to "packet-x11.c".
  
  Handle the failure reply from the initial connection request.
  
  "proto_item_append_text()" accepts "printf"-like formats; we don't need
  to generate a string with a formatting routine and hand it to
  "proto_item_append_text()", so don't do so.
  
  When doing reassembly, the length that should be checked is the length
  remaining in the tvbuff, not the length remaining in the packet, and
  that length should be fetched with "tvb_ensure_length_remaining()" so
  that if we *do* go past the end of the tvbuff we throw the appropriate
  exception.
  
  To determine whether a reply is a reply to the initial connection, check
  the connection state and "initial connection reply" frame - don't check
  the first byte of the message unless we've determined that the message
  isn't an initial connection reply (the first byte of the initial
  connection reply is the success/failure flag, so it could be 0 or 1).
  
  Display window IDs in hex in replies, as we do in requests.
  
  Fix the masks for Button3, Button4, and Button5 (it's a bitset, not a
  button number - more than one mouse button can be down in an event,
  although it can be a pain to try to click more than one button at the
  same time).
  
  Revision  Changes    Path
  1.3       +1 -106    ethereal/packet-x11-keysymdef.h
  1.50      +196 -79   ethereal/packet-x11.c
  1.11      +13 -11    ethereal/x11-fields