Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-fix.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxx>
Date: Thu, 12 Jun 2003 03:02:47 -0500 (CDT)
guy         2003/06/12 03:02:47 CDT

  Modified files:
    .                    packet-fix.c 
  Log:
  Heuristic dissectors are not allowed to return FALSE after they've done
  something to the protocol tree or the columns, as that leaves crud in
  the protocol tree that could mess up whatever stuff subsequent
  dissection code does with the packet.
  
  Get rid of all column-setting code before the initial sanity checking
  code, and have that code just return FALSE rather than putting
  "Malformed FIX Packet" indications (if the dissector returns FALSE, it's
  saying the packet *isn't* a FIX packet, not that it is one but that it's
  malformed).  After we've set the columns and created the protocol tree,
  return TRUE if we find a problem (we should put an error indication
  there in that case).
  
  Revision  Changes    Path
  1.5       +38 -33    ethereal/packet-fix.c