Wireshark · Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-gtp.c packet-ppp.c packet-ppp.h

[Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>]

guy         2002/11/11 13:23:13 CST

  Modified files:
    .                    packet-gtp.c packet-ppp.c packet-ppp.h 
  Log:
  Instead of tweaking a "Protocol configuration options" extension header
  item to look more-or-less like a PPP packet, just dissect it in place
  and hand off to the appropriate subdissector using the PPP dissector's
  handoff table (which we export, along with its value_string table for
  protocol IDs, which we use to report the protocol ID symbolically).
  
  This means there's no point in having a configurable option to control
  whether to do that tweaking; make it an obsolete option.
  
  Bring "col_get_writable()" back from the dead, and have the GTP
  dissector save the current "writable" flag for columns, mark the columns
  non-writable before calling the subdissector for the PPP configuration
  protocol, and restore the state of the writable flag, rather than
  putting the columns back after the PPP configuration protocol's
  dissector is done.
  
  Fix some more typos in comments.
  
  Don't register the IP dissector in the "ppp.protocol" table in the GTP
  dissector's handoff registration routine - it's already being done in
  the IP dissector's handoff routine.
  
  Fix the name for CHAP to match what RFC 1994 calls it (if the name
  changed, it should be changed in all places, but, at least according to
  this message, a while ago, from Bob Sutterfield, "since the RFC defines
  the protocol, the RFC defines the name":
  
  	http://mail-index.netbsd.org/netbsd-help/1996/05/16/0011.html
  
  and the RFC defines the name as "PPP Challenge Handshake Authentication
  Protocol (CHAP)").
  
  Revision  Changes    Path
  1.46      +38 -34    ethereal/packet-gtp.c
  1.100     +13 -7     ethereal/packet-ppp.c
  1.12      +7 -1      ethereal/packet-ppp.h