Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-dcerpc-netlogon.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ronnie Sahlberg <sahlberg@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 4 Nov 2002 05:52:37 -0600 (CST)
sahlberg    2002/11/04 05:52:37 CST

  Modified files:
    .                    packet-dcerpc-netlogon.c 
  Log:
  Bugfix.
  Previous checkin did not make sense. We can not have a union without having the
  union case value stored as a separate variable or else the receiving side will
  not know how to decode the packet.
  Therefore it can not be a union at all. Instead we have a REF pointer to a ulong
  holding the number of elements, then a unique pointer to a conformant array
  of structures.
  
  Thus, the content of the reply packet for function_24 as well as
  dsrolegetprimarydomaininfo can not be
  
   [ref] PRIMARY_DOMAIN_INFO_EX_UNION *pdi;
  
  but instead MUST be
   long num_entries;
   [unique][size_is(num_entries)] PRIMARY_DOMAIN_INFO_EX *pdi;
  
  Revision  Changes    Path
  1.61      +11 -35    ethereal/packet-dcerpc-netlogon.c