Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal/plugins/docsis packet-docsis.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 20 Jul 2002 19:22:28 -0500 (CDT)
guy         2002/07/20 19:22:21 CDT

  Modified files:
    plugins/docsis       packet-docsis.c 
  Log:
  Offsets in packets should be "int", not "guint8", unless there is an
  *inviolable guarantee* that the offset will *never* be bigger than 255.
  (The same applies for "guint16" and 65535.) Otherwise, you run the risk
  of an infinite loop (packets are not guaranteed to be valid, nor are the
  contents of capture files - and there's no guarantee that you're reading
  a DOCSIS file if you've turned on the "force interpretation as DOCSIS"
  flag.)
  
  Revision  Changes    Path
  1.4       +3 -3      ethereal/plugins/docsis/packet-docsis.c