Ethereal-cvs: Re: [Ethereal-cvs] cvs commit: ethereal packet-smb.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <rsharpe@xxxxxxxxxx>
Date: Tue, 30 Apr 2002 03:47:23 +0930 (CST)
On Mon, 29 Apr 2002, Guy Harris wrote:

> guy         2002/04/29 05:23:06 CDT
> 
>   Modified files:
>     .                    packet-smb.c 
>   Log:
>   There's no need to allocate and fill in an array of sub-authorities and
>   then later construct the sub-authority string from that array; we can
>   just construct the string as we fetch the sub-authorities.
>   
>   Given that we're doing that, use the cleanup handler to free the string,
>   so that we don't leak memory if we throw an exception when fetching the
>   RID, for example.

OK, I see that that does simplify things, and I guess we don't need to see 
the sub-authorities as separate entries in the tree.

Regards
-----
Richard Sharpe, rsharpe@xxxxxxxxxx, rsharpe@xxxxxxxxx, 
sharpe@xxxxxxxxxxxx