Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-ieee80211.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 21 Jun 2001 01:36:45 -0500 (CDT)
guy         2001/06/21 01:36:44 CDT

  Modified files:
    .                    packet-ieee80211.c 
  Log:
  Don't use "tvb_get_ptr()" and "pletohs()" just to fetch a 16-bit
  integral value from a packet - "tvb_get_letohs()" can do that just fine.
  
  Don't use "tvb_get_ptr()", casting the result to a "guint16 *", and
  dereferencing that pointer, either: that doesn't handle byte order
  correctly, and it may fail if the pointer isn't aligned on a 2-byte
  boundary.
  
  For that matter, don't just use "tvb_get_ptr()" and dereference the
  result to get an 8-bit quantity.
  
  Use "proto_tree_add_item()" in many places where it's possible.
  
  Reuse the results of "tvb_get_ptr()" calls when possible.
  
  Show the fragment number and sequence number in decimal - they're just
  ordinals.
  
  Fix the blurb for the sequence number field.
  
  Revision  Changes    Path
  1.32      +48 -102   ethereal/packet-ieee80211.c