Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-fr.h Makefile.am nlpid.h packet-clnp.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 30 Mar 2001 04:51:53 -0600 (CST)
guy         2001/03/30 04:51:53 CST

  Modified files:
    .                    Makefile.am nlpid.h packet-clnp.c 
                         packet-esis.c packet-fr.c packet-isis.c 
                         packet-llc.c packet-lmi.c packet-osi.c 
                         packet-osi.h packet-wcp.c packet-x25.c 
  Added files:
    .                    packet-fr.h 
  Log:
  NLPID's of 0x08 and 0x09 should be labeled as Q.933 and LMI,
  respectively, not Q.931 and Q.2931, in Frame Relay.
  
  When dissecting Q.933-style multiprotocol encapsulated Frame Relay
  frames, use the "osinl" dissector table to check for OSI network layer
  protocols, include the NLPID in the tvbuff you hand to
  "dissector_try_port()" with that dissector table, and put the NLPID into
  the protocol tree as an invisible item - the NLPID is considered part of
  the PDU for those protocols, so you have to include it in the tvbuff,
  and the dissector will put it into the protocol tree.
  
  Also, make sure the top-level entry for the Frame Relay protocol
  includes all the bytes preceding the payload, and none of the payload
  bytes.
  
  Export a routine to do Q.933-style dissection, and have the WCP
  dissector call it, rather than duplicating that code in the WCP
  dissector.
  
  Don't register OSI network layer protocols with the "fr.ietf" dissector
  table; it's now sufficient to register them with the "osinl" dissector
  table, as the Frame Relay dissector now checks that.
  
  Get rid of unnecessary checks for protocols being enabled (if the
  dissector is always called through handles or dissector tables, the
  common code for handles and dissector tables will do the checks for
  you).
  
  Get rid of some unnecessary #includes.
  
  Revision  Changes    Path
  1.297     +2 -1      ethereal/Makefile.am
  1.8       +6 -1      ethereal/nlpid.h
  1.27      +1 -3      ethereal/packet-clnp.c
  1.14      +1 -2      ethereal/packet-esis.c
  1.14      +158 -46   ethereal/packet-fr.c
  1.19      +1 -2      ethereal/packet-isis.c
  1.84      +1 -2      ethereal/packet-llc.c
  1.3       +2 -32     ethereal/packet-lmi.c
  1.41      +5 -5      ethereal/packet-osi.c
  1.6       +6 -3      ethereal/packet-osi.h
  1.8       +6 -37     ethereal/packet-wcp.c
  1.47      +1 -4      ethereal/packet-x25.c