Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal Makefile.am packet-lapb.c packet-x25.c packe

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 12 Feb 2001 03:06:19 -0600 (CST)
guy         2001/02/12 03:06:18 CST

  Modified files:
    .                    Makefile.am packet-lapb.c packet-x25.c 
                         packet-xot.c 
  Removed files:
    .                    packet-x25.h 
  Log:
  If you register more than one field with the same name, the dfilter code
  can now handle that; this allows us to register both the modulo-8 and
  the modulo-128 versions of various X.25 bitfields with "x.25.XXX" names,
  which lets us get rid of the "ex.25" protocol stuff completely and use
  "x.25" for both modulo-8 and modulo-128 X.25.  Do so.  (Also, fix up
  some cases where we appeared to be using the modulo-8 fields when
  dissecting modulo-128 X.25.)
  
  This, in turn, allows us to register the X.25 dissector, as there's now
  only one protocol with which it's associated, and make it static and
  have it called only through a handle, and to, when registering it with
  the "llc.dsap" dissector table, associate it with "proto_x25".
  
  That, in turn, allows us to get rid of the "CHECK_DISPLAY_AS_DATA()"
  calls, and the code to set "pinfo->current_proto", in the X.25
  dissector.
  
  The code for the display filter expression dialog would, if there are
  two fields with the same name registered under a protocol, list both of
  them; have it list only one of them - the fields should have the same
  type, the same radix, and the same value_string/true_false_string table
  if any (if they don't, they're really not the same field...).
  
  Revision  Changes    Path
  1.283     +1 -2      ethereal/Makefile.am
  1.29      +9 -3      ethereal/packet-lapb.c
  1.46      +93 -163   ethereal/packet-x25.c
  1.5       +9 -3      ethereal/packet-xot.c