Ethereal-cvs: Re: [ethereal-cvs] cvs commit: ethereal file.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <sharpe@xxxxxxxxxx>
Date: Tue, 12 Sep 2000 15:18:25 +0900
Sometime today, I, Richard Sharpe, send the following:

>At 10:27 PM 9/11/00 -0500, Guy Harris wrote:
>>guy         2000/09/11 22:27:04 CDT
>>
>>  Modified files:
>>    .                    file.c 
>>  Log:
>>  Also free the GSLists for per-frame data on frames we haven't
>>  re-dissected on a rescan.
>
>Hmmm, this does not seem quite right. If we didn't re-dissect the frame,
then >the per-frame data should still be relevant?

OK, Guy was correct. I originally added those mods because I stumbled over
the problem that init_packet_proto was called and freed up all those items
that the GSLists items point to.

So, we should free those per-frame GSLists always in rescan_packets.


Regards
-------
Richard Sharpe, sharpe@xxxxxxxxxx
Samba (Team member, www.samba.org), Ethereal (Team member, www.zing.org)
Contributing author, SAMS Teach Yourself Samba in 24 Hours
Author, Special Edition, Using Samba